Nttp support #1609
Merged
Nttp support #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 121 121
Lines 3420 3420
=======================================
Hits 2764 2764
Misses 656 656 |
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
======================================
Coverage 81.1% 81.1%
======================================
Files 124 124
Lines 3476 3476
======================================
Hits 2819 2819
Misses 657 657 |
horenmar
reviewed
May 7, 2019
horenmar
reviewed
May 7, 2019
|
Apart from the two documentation nitpicks this looks fine. |
JoeyGrajciar
force-pushed
the
nttp_support
branch
2 times, most recently
from
ee43393 to
cfd92da
Compare
Codecov Report
@@ Coverage Diff @@
## master #1609 +/- ##
=======================================
Coverage 81.05% 81.05%
=======================================
Files 124 124
Lines 3478 3478
=======================================
Hits 2819 2819
Misses 659 659 |
JoeyGrajciar
force-pushed
the
nttp_support
branch
from
587cf1d to
80c551f
Compare
JoeyGrajciar
force-pushed
the
nttp_support
branch
from
80c551f to
a6e9333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for non type template parameters in form of signature based tests
TEMPLATE_TEST_CASE_SIG,TEMPLATE_TEST_CASE_METHOD_SIG,TEMPLATE_PRODUCT_TEST_CASE_SIG,TEMPLATE_PRODUCT_TEST_CASE_METHOD_SIGGitHub Issues
Closes #1531