Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch2 documentation says "This limitation is highly unlikely to be lifted before Catch 2 is released" #1302

Closed
reddwarf69 opened this issue May 31, 2018 · 3 comments

Comments

@reddwarf69
Copy link
Contributor

I'm just reading about Catch for first time. Finding "This limitation is highly unlikely to be lifted before Catch 2 is released" in https://github.com/catchorg/Catch2/blob/master/docs/limitations.md is confusing.

@onqtam
Copy link

onqtam commented Jun 1, 2018

Catch2 is based on top of C++11 and making asserts thread safe is much easier. That is planned for Catch2 but not implemented yet. For Catch 1 however that feature will never be implemented.

@horenmar
Copy link
Member

horenmar commented Jun 1, 2018

Pretty much the above: There was a slight possibility that someone would be crazy enough to implement it in C++98, or add extra compile time configuration branches for it. At some point it should become part of Catch2, as C++11 makes it much easier, but it is not in yet.

How did you read it? Would it help if it said something along the lines of "not supported in Catch v1.x, not going to be supported in Catch v1.x, but there are plans for support in Catch v2.x"?

@reddwarf69
Copy link
Contributor Author

Yes, that would be more clear.

"This limitation is highly unlikely to be lifted before Catch 2 is released"... Well it's not "highly unlikely", it's literally impossible. The probability is exactly zero. Catch 2 has already been released. So I reached the conclusion that the text was out of date, the information was not reliable and so it was equally possible that Catch 2 supported or not supported thread safe assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants