Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behat test runs dies #323

Open
cybernotic opened this issue Jul 15, 2023 · 3 comments
Open

Behat test runs dies #323

cybernotic opened this issue Jul 15, 2023 · 3 comments

Comments

@cybernotic
Copy link
Contributor

cybernotic commented Jul 15, 2023

Hi, After this commit was made 4aa5976 our moodle-docker behat tests finishes in 0 seconds with no results.
I forked this repo and made a change in tests/behat/behat_auth_outage.php line 33: #defined('MOODLE_INTERNAL') || die();
This resolved our issue.
Please can you look in to this or is there somthing we would need to do at our end because MOODLE_INTERNAL is not defined?

@aspark21
Copy link

@cybernotic can you submit a merge request for this fix.

@aspark21
Copy link

Seems this slipped through the net because behat running is disabled in this plugin's ci config https://github.com/catalyst/moodle-auth_outage/blob/MOODLE_39_STABLE/.github/workflows/ci.yml#L10

@cybernotic
Copy link
Contributor Author

@cybernotic can you submit a merge request for this fix.

merge request sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants