New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check to ensure version.php changes (e.g. a version bump / change) when CSS/JS, DB or lang string files are updated #49

Open

keevan opened this issue Jun 30, 2022 · 0 comments

Labels

Contributor

keevan commented Jun 30, 2022 •

edited

Loading

Which ultimately results in less things that need to be manually reviewed, if it simply fails via the CI.

Example of note during a review:
catalyst/moodle-tool_dataflows#245 (comment)

Example of it being missed during review:
https://github.com/catalyst/moodle-tool_dataflows/pull/249/files

The more things the reusable workflows can check, the less feedback loops we need during peer review whilst retaining quality. 😃 💎

keevan added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment