Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] unable to download in .mp3 #149

Open
sys-admn-ploopy opened this issue Aug 20, 2024 · 3 comments
Open

[BUG] unable to download in .mp3 #149

sys-admn-ploopy opened this issue Aug 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@sys-admn-ploopy
Copy link

sys-admn-ploopy commented Aug 20, 2024

Describe the bug
As the title says, I am unable to download filed in .mp3 files, with the downloads failing after max retries. Downloading in "raw format" works okay, but it would be nice to have song metadata/ album art... Not sure if I am doing something wrong on my end

I do have ffmpeg downloaded to PATH but it doesn't seem to be recognized:

[2024-08-19 22:30:50,789 :: worker.downloader.SESSION_DL_TH-a :: worker/downloader.py -> 222:      download_track() :: ERROR] -> Download failed for track by id '2cDCojn6uIBM6A5xTAbl3H', Unexpected error: Traceback (most recent call last):
  File "worker/downloader.py", line 168, in download_track
  File "utils/spotify.py", line 217, in convert_audio_format
  File "subprocess.py", line 408, in check_call
  File "subprocess.py", line 389, in call
  File "subprocess.py", line 1024, in __init__
  File "subprocess.py", line 1901, in _execute_child
FileNotFoundError: [Errno 2] No such file or directory: 'ffmpeg'
 !

for reference, my output for brew install ffmpeg:

➜  ~ brew install ffmpeg
==> Downloading https://formulae.brew.sh/api/formula.jws.json
######################################################################### 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
######################################################################### 100.0%
Warning: ffmpeg 7.0.2 is already installed and up-to-date.
To reinstall 7.0.2, run:
  brew reinstall ffmpeg

Would appreciate any advice! tbh I may have downloaded ffmpeg incorrectly tbh...

System Information:

  • OS: MacOS
  • OnTheSpot Version: 0.5

Additional context

@sys-admn-ploopy sys-admn-ploopy added the bug Something isn't working label Aug 20, 2024
@justin025
Copy link

How did you get it to run on iOS lmao

@sys-admn-ploopy
Copy link
Author

How did you get it to run on iOS lmao

Oops, I meant MacOS lol

@justin025
Copy link

justin025 commented Aug 21, 2024

I was looking at releases and cant seem to find a macos build, I'm assuming you built it yourself? If that is the case try embedding the following binaries. Create a folder titled 'ffbin_mac' and place ffmpeg ffprobe and ffplay in the directory. Here is the build script for reference, https://github.com/casualsnek/onthespot/blob/main/build_mac.sh

If you have trouble with this I could build you a binary when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants