-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Colbert MLX #1866
base: master
Are you sure you want to change the base?
Add Colbert MLX #1866
Conversation
Side Note: We have some duplicated code e.g. pyserini/pyserini/encode/_tct_colbert.py Line 72 in 184a212
and pyserini/pyserini/search/faiss/_searcher.py Line 147 in 184a212
Is there a particular reason we are keeping both? |
@jacklin64 @justram can either of you take a look at this? |
Bump on this @jacklin64 @justram . Evaluating with this python -m pyserini.search.faiss \
--index msmarco-v1-passage.tct_colbert.hnsw \
--topics msmarco-passage-dev-subset \
--encoder castorini/tct_colbert-msmarco \
--encoder-class mlx_tct_colbert \
--output runs/run.msmarco-passage.tct_colbert.hnsw.tsv \
--output-format msmarco \
--use_mlx
|
Could probably do with some redesign but here's a first pass at integrating MLX into Pyserini with ColBERT.
The tests and test outputs are similar to the same tests for the PyTorch hugging face implementation