-
Notifications
You must be signed in to change notification settings - Fork 471
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Abstract away
ReaderWriterLockSlim in most cases
`ReaderWriterLockSlim` is used mostly in conjunction with regular dictionaries. The double-checked lock pattern is used in many places to query and update those dictionaries. Instead of repeating this same pattern over and over again, abstract it away with a dictionary-like type `SynchronizedDictionary<,>` that performs the required locking pattern. `ModuleScope`'s internal methods for accessing the type cache can now be replaced with a simple internal property `TypeCache`.
- Loading branch information
Showing
12 changed files
with
154 additions
and
217 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
src/Castle.Core/Core/Internal/SynchronizedDictionary.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| // Copyright 2004-2018 Castle Project - http://www.castleproject.org/ | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| namespace Castle.Core.Internal | ||
| { | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Threading; | ||
|
|
||
| internal sealed class SynchronizedDictionary<TKey, TValue> : IDisposable | ||
| { | ||
| private Dictionary<TKey, TValue> items; | ||
| private ReaderWriterLockSlim itemsLock; | ||
|
|
||
| public SynchronizedDictionary() | ||
| { | ||
| items = new Dictionary<TKey, TValue>(); | ||
| itemsLock = new ReaderWriterLockSlim(LockRecursionPolicy.NoRecursion); | ||
| } | ||
|
|
||
| [Obsolete] // TODO: Remove this property along with the `ModuleScope.Lock` property. | ||
| public ReaderWriterLockSlim Lock => itemsLock; | ||
|
|
||
| public void AddOrUpdateWithoutTakingLock(TKey key, TValue value) | ||
| { | ||
| items[key] = value; | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| itemsLock.Dispose(); | ||
| } | ||
|
|
||
| public TValue GetOrAdd(TKey key, Func<TKey, TValue> valueFactory) | ||
| { | ||
| TValue value; | ||
|
|
||
| itemsLock.EnterReadLock(); | ||
| try | ||
| { | ||
| if (items.TryGetValue(key, out value)) | ||
| { | ||
| return value; | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| itemsLock.ExitReadLock(); | ||
| } | ||
|
|
||
| itemsLock.EnterWriteLock(); | ||
| try | ||
| { | ||
| return GetOrAddWithoutTakingLock(key, valueFactory); | ||
| } | ||
| finally | ||
| { | ||
| itemsLock.ExitWriteLock(); | ||
| } | ||
| } | ||
|
|
||
| public TValue GetOrAddWithoutTakingLock(TKey key, Func<TKey, TValue> valueFactory) | ||
| { | ||
| TValue value; | ||
|
|
||
| if (items.TryGetValue(key, out value)) | ||
| { | ||
| return value; | ||
| } | ||
| else | ||
| { | ||
| value = valueFactory.Invoke(key); | ||
| items.Add(key, value); | ||
| return value; | ||
| } | ||
| } | ||
|
|
||
| public void ForEach(Action<TKey, TValue> action) | ||
| { | ||
| itemsLock.EnterReadLock(); | ||
| try | ||
| { | ||
| foreach (var item in items) | ||
| { | ||
| action.Invoke(item.Key, item.Value); | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| itemsLock.ExitReadLock(); | ||
| } | ||
| } | ||
|
|
||
| [Obsolete] // TODO: Remove this method along with the `ModuleScope.GetFromCache` method. | ||
| public bool TryGetValueWithoutTakingLock(TKey key, out TValue value) | ||
| { | ||
| return items.TryGetValue(key, out value); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.