Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the JSON data in load #36

Merged
merged 14 commits into from
Dec 14, 2017
Merged

Validate the JSON data in load #36

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
cc4c70d
Validate the JSON data in load
ashleym1972 Jun 29, 2017
02e7162
Raise error on bad response data
ashleym1972 Jun 29, 2017
a8ad97a
Bad request constant
ashleym1972 Jun 29, 2017
9a88090
Add test for invalid JSON error
ashleym1972 Jun 29, 2017
bc64508
Add test for handling invalid response data
ashleym1972 Jun 29, 2017
77fee61
Fix typo
ashleym1972 Jun 29, 2017
6abd5cd
Use nil instead of blank
ashleym1972 Jun 29, 2017
8928ba2
Use key instead of blank
ashleym1972 Jun 29, 2017
3fcaadf
Change .nil? checks to .key?
ashleym1972 Jul 24, 2017
c8121f6
Change error from bad data code to invalid json message
ashleym1972 Jul 24, 2017
bd14277
oops
ashleym1972 Jul 24, 2017
82a2076
Fix test
ashleym1972 Jul 24, 2017
9b90bb1
Fix error
Jul 25, 2017
beeb140
Fix sign response
Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/u2f/register_response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ def self.load_from_json(json)
raise RegistrationError, code: data['errorCode']
end

if data['clientData'].blank? || data['registrationData'].blank?
raise RegistrationError, code: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the code in a constant, for clarity

end

instance = new
instance.client_data_json =
::U2F.urlsafe_decode64(data['clientData'])
Expand Down