Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no existing tags creates a 0.0.0 format tag #41

Closed
wants to merge 1 commit into from
Closed

fix: no existing tags creates a 0.0.0 format tag #41

wants to merge 1 commit into from

Conversation

erikbrgn
Copy link

@erikbrgn erikbrgn commented Feb 22, 2024 •
edited
Loading

I've created a test which showcases the issue. This is the results from the test:

 1) plugin
       should increment version without existing tags:

      AssertionError: expected '0.0.1.0' to equal '24.2.1'
      + expected - actual

      -0.0.1.0
      +24.2.1

closes #37

@erikbrgn
Copy link
Author

I'll make an attempt at fixing it.

@erikbrgn
Copy link
Author

After having a look at node-calver, it seems this issue can be bypassed by simply specifying calendar as increment.

Closing this PR for now.

@erikbrgn erikbrgn closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial release version is v0.0.0
1 participant
@erikbrgn