Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mozilla Addon SDK. #4518

Closed
wants to merge 1 commit into from
Closed

Conversation

kud
Copy link
Contributor

@kud kud commented May 23, 2014

No description provided.

@vitorgalvao
Copy link
Member

I really don’t see this as a good addition to the project. Downloading an installer the user has to call manually is one thing, but downloading something that the user has to manually insert terminal commands to complete just sounds like too much work (consider that mitigating that is the whole point). It also assumes quite a few things about the user’s installation, that are not being checked.

I propose a rejection of the cask, but let’s get a few more eyes in, in case I’m missing something.
@rolandwalker @fanquake @nanoxd.

@kud
Copy link
Contributor Author

kud commented May 23, 2014

I understand your point @vitorgalvao but I hate so much downloading zip files... mostly that I've got my OS handler (https://github.com/kud/my) to have the same settings on all my devices.

I don't imagine now downloading a file without brew, cask or git in fact.

Maybe it should be in brew instead of cask, I don't know.

@rolandwalker
Copy link
Contributor

No need to reject, I think; there's a simple solution.

@kud as I suggested in IRC, just get rid of the caveats stanza and put in the following

  binary 'addon-sdk-1.16/bin/cfx'

That will have the effect of linking cfx to /usr/local/bin/cfx .

@vitorgalvao
Copy link
Member

Thank you for catching that, @rolandwalker. My fault for relying only on the apparent complexity of the instructions, instead of downloading and checking for a solution. It is indeed quite simple (particularly in retrospect, naturally).

Not too comfortable it assumes quite a bit about your setup (not only installed applications but also specific versions of development languages), so I do think those should at least be mentioned in the caveats, depending on how useful/necessary it’d actually be to people who would install this cask. I’ll defer to @kud on that, since I’ve never used this particular piece of software, nor do I know anything about its user base.

@passcod
Copy link
Contributor

passcod commented May 24, 2014

This belongs in Homebrew proper, really. Unless I'm mistaken, there's no GUI (apart from docs that open in a browser) for this, it's a CLI development tool.

@kud
Copy link
Contributor Author

kud commented May 24, 2014

Yep I think it's definitely an homebrew Formula more than cask one. I'll
close my pr and do something with homebrew. Thanks.
On 24 May 2014 07:23, "Félix Saparelli" [email protected] wrote:

This belongs in Homebrew proper, really. Unless I'm mistaken, there's no
GUI for this, it's a CLI development tool.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4518#issuecomment-44078264
.

@kud kud closed this May 24, 2014
@tapeinosyne
Copy link
Contributor

We should open a new issue (or just use #4228) to allow the core maintainers to discuss and decide on what is appropriate for Cask; the topic has hijacked two issues in the past week alone, as there is no rule that can be consistently applied.

@kud
Copy link
Contributor Author

kud commented May 24, 2014

In any case, I did a brew formula instead of cask formula. ;)

@tapeinosyne
Copy link
Contributor

Glad to know that you worked out a solution, @kud. Thanks for contributing.

@kud
Copy link
Contributor Author

kud commented May 24, 2014

You're welcome; I have multiple devices and need a sync script for them ;) done via brew/cask.

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
@kud kud deleted the formula.mozilla-addon-sdk branch November 26, 2018 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants