-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mozilla Addon SDK. #4518
Add Mozilla Addon SDK. #4518
Conversation
I really don’t see this as a good addition to the project. Downloading an installer the user has to call manually is one thing, but downloading something that the user has to manually insert terminal commands to complete just sounds like too much work (consider that mitigating that is the whole point). It also assumes quite a few things about the user’s installation, that are not being checked. I propose a rejection of the cask, but let’s get a few more eyes in, in case I’m missing something. |
I understand your point @vitorgalvao but I hate so much downloading zip files... mostly that I've got my OS handler (https://github.com/kud/my) to have the same settings on all my devices. I don't imagine now downloading a file without brew, cask or git in fact. Maybe it should be in brew instead of cask, I don't know. |
No need to reject, I think; there's a simple solution. @kud as I suggested in IRC, just get rid of the binary 'addon-sdk-1.16/bin/cfx' That will have the effect of linking |
Thank you for catching that, @rolandwalker. My fault for relying only on the apparent complexity of the instructions, instead of downloading and checking for a solution. It is indeed quite simple (particularly in retrospect, naturally). Not too comfortable it assumes quite a bit about your setup (not only installed applications but also specific versions of development languages), so I do think those should at least be mentioned in the caveats, depending on how useful/necessary it’d actually be to people who would install this cask. I’ll defer to @kud on that, since I’ve never used this particular piece of software, nor do I know anything about its user base. |
This belongs in Homebrew proper, really. Unless I'm mistaken, there's no GUI (apart from docs that open in a browser) for this, it's a CLI development tool. |
Yep I think it's definitely an homebrew Formula more than cask one. I'll
|
We should open a new issue (or just use #4228) to allow the core maintainers to discuss and decide on what is appropriate for Cask; the topic has hijacked two issues in the past week alone, as there is no rule that can be consistently applied. |
In any case, I did a brew formula instead of cask formula. ;) |
Glad to know that you worked out a solution, @kud. Thanks for contributing. |
You're welcome; I have multiple devices and need a sync script for them ;) done via brew/cask. |
No description provided.