Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ChildrenTag.Root to be a weird value #2434

Open
JakeWharton opened this issue Nov 7, 2024 · 0 comments
Open

Migrate ChildrenTag.Root to be a weird value #2434

JakeWharton opened this issue Nov 7, 2024 · 0 comments

Comments

@JakeWharton
Copy link
Collaborator

Like 100,000. This will prevent its accidental use with regular widgets whose children are likely to be numbered with the current value of 1.

Unfortunately we need to do a deprecation cycle here, as guest code will be expecting the value to be 1.

@Test fun constants() {
// This is otherwise a change-detector test, but since these values are included in
// the serialized form they must never change.
assertThat(Id.Root.value).isEqualTo(0)
assertThat(ChildrenTag.Root.value).isEqualTo(1)
}

@JakeWharton JakeWharton changed the title Migrate ChidlrenTag.Root to be a weird value Migrate ChildrenTag.Root to be a weird value Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant