Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies from paging-runtime-uikit on multiplatformized paging-runtime classes #71

Open
veyndan opened this issue Feb 27, 2023 · 0 comments

Comments

@veyndan
Copy link
Collaborator

veyndan commented Feb 27, 2023

PagingCollectionViewController's implementation currently mimics that of PagingDataAdapter. This is conceptually convenient when comparing implementations, but I'm doubtful that anyone actually does this (including myself since implementing this).

Having the implementations mimic each other requires a fair bit of multiplatformication overhead. PagingDataAdapter exists in paging-runtime, so therefore (unsurprisingly) depends on other paging-runtime classes (like AsyncPagingDataDiffer), and these classes in turn depend on some RecyclerView classes. All these dependencies of PagingDataAdapter required multiplatformizing, as can be seen here.

Instead of having to maintain a multiplatformized fork of paging-runtime, is it possible for paging-runtime-uikit to just use classes found in paging-common? For example, depending on PagingDataDiffer (found in paging-common) instead of AsyncPagingDataDiffer (found in paging-runtime).

CC @ianhanniballake @yigit @claraf3 @dlam @swankjesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant