Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refuse to clobber #2

Open
casey opened this issue Sep 4, 2019 · 0 comments
Open

Refuse to clobber #2

casey opened this issue Sep 4, 2019 · 0 comments

Comments

@casey
Copy link
Owner

casey commented Sep 4, 2019 •
edited
Loading

Two instances of bak can clobber each others backups. Since bak is explicitly intended to save data, users probably don't want this. So, bak should never clobber data. I suspect fixing this will probably involve forsaking std::fs::rename for something os-specific.

Ideally, bak should keep trying until it successfully renames a file.
@casey casey changed the title Avoid clobbering race condition Refuse to clobber Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@casey