Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix integer priority sorting #327

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

nschwane
Copy link
Contributor

@nschwane nschwane commented Oct 18, 2023

Fix for #326. Fixes policy sorting with priorities if priorities are numbers.

Fix: #326

@casbin-bot
Copy link
Member

@Nekotoxin please review

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@hsluoyz hsluoyz changed the title fix: fix integer priority sorting feat: fix integer priority sorting Oct 18, 2023
@hsluoyz
Copy link
Member

hsluoyz commented Oct 18, 2023

@nschwane plz fix CI:

image

@nschwane
Copy link
Contributor Author

@nschwane plz fix CI:

image

Fixed

@hsluoyz hsluoyz merged commit d5cd58a into casbin:master Oct 18, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
# [1.32.0](v1.31.2...v1.32.0) (2023-10-18)

### Features

* fix integer priority sorting ([#327](#327)) ([d5cd58a](d5cd58a))
@github-actions
Copy link

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nschwane nschwane deleted the fix/priority_sorting branch October 18, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policies with explicit integer priorities are not sorted correctly
4 participants