Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of HTTP-sourced files #682

Closed
pivotaljohn opened this issue Jun 2, 2022 · 0 comments
Closed

Better handling of HTTP-sourced files #682

pivotaljohn opened this issue Jun 2, 2022 · 0 comments
Labels
bug This issue describes a defect or unexpected behavior good first issue An issue that will be a good candidate for a new contributor priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.

Comments

@pivotaljohn
Copy link
Contributor

pivotaljohn commented Jun 2, 2022

Describe the problem/challenge you have
As described here: carvel-dev/kapp#521 (comment) ...

Whenever an HTTP GET is performed, if the response succeeds but is a non-200 result, that response is being read as the contents of the named fail.

Describe the solution you'd like
Whenever there is a non-200 response from the HTTP resource, stop and report that error instead of processing the response given (which will never be the desired resource).

Anything else you would like to add:
This is the exact same issue fixed by: carvel-dev/kapp#523


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@pivotaljohn pivotaljohn added enhancement This issue is a feature request priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. bug This issue describes a defect or unexpected behavior good first issue An issue that will be a good candidate for a new contributor and removed enhancement This issue is a feature request labels Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior good first issue An issue that will be a good candidate for a new contributor priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome.
Projects
None yet
Development

No branches or pull requests

1 participant