Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't install on old fedora #384

Open
jkremser opened this issue May 22, 2024 · 2 comments
Open

can't install on old fedora #384

jkremser opened this issue May 22, 2024 · 2 comments
Labels
bug This issue describes a defect or unexpected behavior duplicate This issue is already captured by another issue

Comments

@jkremser
Copy link

jkremser commented May 22, 2024

can't install on Fedora (pretty old one (35), but still)

I am missing the shasum binary that's required by the installation script. I have sha1sum binary present, but it has slightly different contract, so that even if I alias or symlink the shasum -> sha1sum, it can't pass the followin check:

 shasum -v 1>/dev/null 2>&1 || (echo "Missing shasum binary" && exit 1)

(which is present in your install script)

sha1sum uses either sha1sum --version or sha1sum --v

sha1sum --v
sha1sum (GNU coreutils) 8.32
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

sha1sum -v
sha1sum: invalid option -- 'v'
Try 'sha1sum --help' for more information.

I'd contribute and make the script working, but it can't be found in this repo.

<3

@jkremser jkremser added bug This issue describes a defect or unexpected behavior carvel-triage This issue has not yet been reviewed for validity labels May 22, 2024
@renuy renuy added duplicate This issue is already captured by another issue and removed carvel-triage This issue has not yet been reviewed for validity labels May 24, 2024
@praveenrewar
Copy link
Member

Hey @jkremser! Thank you so much for opening the issue and willing to contribute. The scripts are in https://github.com/carvel-dev/carvel, and we have an existing similar issue present there. We would be happy to review a PR if you want to contribute a fix ❤️

@joaopapereira
Copy link
Member

For a pointer, this script is autogenerated so any change would need to be done in https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior duplicate This issue is already captured by another issue
Projects
Status: No status
Development

No branches or pull requests

4 participants