Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[builder] add imgpkg as builder #56

Open
cppforlife opened this issue Oct 21, 2020 · 5 comments
Open

[builder] add imgpkg as builder #56

cppforlife opened this issue Oct 21, 2020 · 5 comments
Labels
enhancement This issue is a feature request

Comments

@cppforlife
Copy link
Contributor

cppforlife commented Oct 21, 2020

github.com/k14s/imgpkg is a builder that can create images from a set of files. let's have that as a backend. there probably needs to be two options: regular or bundle.

for bundles, i think we should have an option to run kbld to update images.yml

@voor
Copy link

voor commented Sep 24, 2021

This concept just blew my mind.

So instead of imgpkg push I would have a kbld configuration in my package cr that says "go to this folder for your bundle" and it would generate the bundle right there?

@cppforlife
Copy link
Contributor Author

So instead of imgpkg push I would have a kbld configuration in my package cr that says "go to this folder for your bundle" and it would generate the bundle right there?

right, for convenience however we would probably want to run kbld on the bundle itself (aka recursive call), but that requires a bit of gymnastics in non-trivial cases (e.g. kbld <(helm template ...)) and then we start getting into business of running other commands (which isnt a business i think we should be in).

@voor
Copy link

voor commented Oct 9, 2021

With helm we probably need better tutorials and documentation on how vendir can help and kapp-controller will do the helm template step for you.

@cppforlife
Copy link
Contributor Author

kapp-controller will do the helm template step for you.

yeah, but we still need kbld to collect images to write out .imgpkg/images.yml at the build time.

@voor
Copy link

voor commented Oct 11, 2021

kapp-controller will do the helm template step for you.

yeah, but we still need kbld to collect images to write out .imgpkg/images.yml at the build time.

🤯 You're totally right, now I'm not sure how this will work

@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 25, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request
Projects
Status: To Triage
Development

No branches or pull requests

2 participants