Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull imgpkg bundle contents from a tarball #223

Open
lisamburns opened this issue Aug 26, 2021 · 5 comments
Open

Pull imgpkg bundle contents from a tarball #223

lisamburns opened this issue Aug 26, 2021 · 5 comments
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@lisamburns
Copy link

Describe the problem/challenge you have
I am creating imgpkg bundles for distribution as .tar files.
These bundle contents have CRDs and other resource definitions, and do not have any images that need to be relocated. In order to extract the contents from the bundle, I still have to relocate the tarball to a registry first, which seems odd.

imgpkg copy --tar <path-to-tarball> --to-repo <myregistry/mybundle>
imgpkg pull -b <myregistry/mybundle> -o /tmp/bundlecontent
kubectl apply -f /tmp/bundlecontent

Describe the solution you'd like
A CLI that extracts from the tar I downloaded directly to the bundle contents without the need to copy to a registry first.
imgpkg build --tar -o

Anything else you would like to add:
This is the reverse/opposite of this issue: #55
Slack thread: https://vmware.slack.com/archives/CUK1X0Z8Q/p1629931739341500
@aaronshurley


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@lisamburns lisamburns added carvel triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Aug 26, 2021
@DennisDenuto
Copy link
Contributor

Hey @lisamburns

Thanks for creating this issue!

Yeah I agree that the workflow you explained is odd. It requires additional steps and network overhead to use content available on local disk.

I think some further iteration on the command name should be done. My first thought is to change imgpkg build -> imgpkg extract. Perhaps even amuse the idea of adding this to the imgpkg pull command? (i.e. imgpkg pull -b root-bundle --tar <tar> -o /tmp/root-bundle)

Also, In your example, there aren't any images referenced by the bundle. But a bundle could reference hundreds of images, and if nested bundles are used, that number can be quite high. This new feature should allow the user to filter which images / bundles in a tar to extract.

I'm going to carvel accept this issue, meaning we plan on working on it in the future :-)

@DennisDenuto DennisDenuto added carvel accepted This issue should be considered for future work and that the triage process has been completed priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. and removed carvel triage This issue has not yet been reviewed for validity labels Aug 31, 2021
@adamfowleruk
Copy link

BUMP. Can we please reprioritise this.

@aaronshurley
Copy link
Contributor

Thanks for the bump @adamfowleruk.

@joaopapereira What are your thoughts on this?

@joaopapereira
Copy link
Member

I like the idea that Dennis pointed out about the extract command, I think it would be easier to understand. Nevertheless, I think that we talked in the past about a reverse build option in #55 and decided to keep the push instead of creating a new command. Given that I think the implementation of
imgpkg pull --tar <tar> -o /tmp/root-bundle
It is something that can be done.

In terms of priority, not sure how high we can make this due to other topics that we are working on right now. But I am going to change it to a higher priority.

@joaopapereira joaopapereira added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/unprioritized-backlog Higher priority than priority/awaiting-more-evidence but not planned. Contributions are welcome. labels Mar 18, 2022
@joaopapereira
Copy link
Member

If this is something that is currently blocking yll let us know and we can see how might we adjust priorities in order to help you out.

@aaronshurley aaronshurley moved this to To Triage in Carvel Jul 25, 2022
@github-project-automation github-project-automation bot moved this to To Triage in Carvel Feb 14, 2023
@joaopapereira joaopapereira moved this from To Triage to Unprioritized in Carvel Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Unprioritized
Development

No branches or pull requests

5 participants