Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When copying a bundle that have images in a private registry copy fails #146

Closed
joaopapereira opened this issue May 10, 2021 · 1 comment
Assignees
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed

Comments

@joaopapereira
Copy link
Member

What steps did you take:
Scenario: When a bundle has images that are in a private repository, copy the bundle to a different registry. When trying to copy the bundle again, imgpkg reaches the original location instead of the location the bundle is being copied from.

Private repository:
repo.io/my-img

  1. Push bundle to public.repo.io/my-bundle that includes repo.io/my-img
  2. Copy bundle from public.repo.io/my-bundle to different.repo.io/my-bundle
  3. Try to copy different.repo.io/my-bundle to yet-another.repo.io/my-bundle

What happened:
imgpkg tries to check if the images are bundles, based on the original location instead of using the PrimaryLocation() function.

What did you expect:
imgpkg should try to check if an image is a bundle, based on the primary location, which first is the same repository as the bundle, and only after should check it from the original location.

Anything else you would like to add:
The problem starts in https://github.com/vmware-tanzu/carvel-imgpkg/blob/develop/pkg/imgpkg/bundle/bundle_images_lock.go#L41

Environment:

  • imgpkg version (use imgpkg --version): 0.7.0
  • Docker registry used (e.g. Docker HUB): gcr.io
  • OS (e.g. from /etc/os-release): macOS Big Sur

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@joaopapereira joaopapereira added bug This issue describes a defect or unexpected behavior carvel triage This issue has not yet been reviewed for validity labels May 10, 2021
@pivotaljohn pivotaljohn added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed carvel triage This issue has not yet been reviewed for validity labels May 11, 2021
@joaopapereira joaopapereira self-assigned this May 13, 2021
@joaopapereira
Copy link
Member Author

Released in version 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes a defect or unexpected behavior carvel accepted This issue should be considered for future work and that the triage process has been completed
Projects
None yet
Development

No branches or pull requests

2 participants