Proposal : Building tarred bundles without being dependent on a OCI registry #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carvel canceled.
|
…egistry Signed-off-by: ashpect <[email protected]>
joaopapereira
requested changes
Apr 12, 2024
There was a problem hiding this comment.
I think that the Proposal looks good, the only thing that I would add to it is a paragraph to enfasize that imgpkg push --to-oci-tar will only create in disk the OCI image for the bundle itself. In the future we can have the inflate flag that might help with that use case.
I also added some answers for the open questions.
After we add this I think the proposal is ready to be approved.
I am sorry for the delay to get this proposal through.
Signed-off-by: ashpect <[email protected]>
joaopapereira
requested changes
Apr 22, 2024
proposals/repo-to-tar/README.md
Outdated
| --- | ||
| title: "Building tarred bundles without being dependent on a OCI registry" | ||
| authors: [ "Ashish Kumar <[email protected]>" ] | ||
| status: "draft" |
There was a problem hiding this comment.
Suggested change
| status: "draft" | |
| status: "review" |
Signed-off-by: ashpect <[email protected]>
Signed-off-by: ashpect <[email protected]>
Signed-off-by: ashpect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step in the direction for resolving the issue 1277.
For discussion, see PR 692