Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration and secrets management #1072

Open
jychp opened this issue Jan 6, 2023 · 2 comments
Open

Improve configuration and secrets management #1072

jychp opened this issue Jan 6, 2023 · 2 comments
Labels
long-term-improvement A better way of doing things

Comments

@jychp
Copy link
Collaborator

jychp commented Jan 6, 2023

In the current version, configuration can be painfull because it's inconsistant.

Exemple :

  • GSuite intel use hardcoded VAR ENV
  • GitHub use VAR ENV defined by an argparse argument

Creating new intel lead to many errors.

Consider switching to DynaConf (or other similar package) to :

  • load non sensitive configuration from file
  • override that conf with env
  • use autoload (.env)
  • add Vault support for secrets

I can help for the migration.

@achantavy achantavy added the long-term-improvement A better way of doing things label Jan 13, 2023
@juju4
Copy link
Contributor

juju4 commented Feb 4, 2023

There are certainly options where a real configuration file would be better than just cli or environment variable (some source for which query could be customizable for example)
As for secrets, I would want to be able to fetch them from cloud vault (azure keyvault & co), not just hashicorp vault.

This could also help to make cartography poll only sources for which it has configuration, instead of always doing all and output unneeded error messages.

@achantavy
Copy link
Contributor

Config file support in progress in #1124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long-term-improvement A better way of doing things
Projects
None yet
Development

No branches or pull requests

3 participants