Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

White Container background #32

Open
danekt opened this issue Jan 25, 2024 · 1 comment
Open

White Container background #32

danekt opened this issue Jan 25, 2024 · 1 comment

Comments

@danekt
Copy link

danekt commented Jan 25, 2024

When I use a <Container>, a white background is generated in the source code <td style=3D"width:37.5em;background:#ffffff"> and I have to use !important property :(

<script lang="ts">
  import {Container} from 'svelte-email';
  const container = {
    backgroundColor: '#313a50',
    color: '#ffffff',
  }
</script>

<Html>
  <Head>
    <style>
      td {
        background-color: #313a50 !important;
      }
    </style>
  </Head>
  <Container style={container}>
    Text
  </Container>
</Html>

I suggest not generate a white background as default for the container.
This was referenced Mar 5, 2024
Open
Open
@cmjoseph07
Copy link

@danekt

I thought about this issue for awhile in a community run forked repo Svelty-email as I wasn't sure if people would be relying on this default style without knowing. But, after a bit of consideration I feel that a library as this should not enforce style and just provide base components that individuals can use to quick template generation. Thus, in said forked repo I have updated to remove this base default bg style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danekt @cmjoseph07