Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] disable make check all for workshop template #551

Open
fmichonneau opened this issue Feb 24, 2021 · 0 comments
Open

[GitHub Actions] disable make check all for workshop template #551

fmichonneau opened this issue Feb 24, 2021 · 0 comments

Comments

@fmichonneau
Copy link
Contributor

because we use the styles repository for things that are not always lessons (e.g. the workshop template), we need to adjust when make lesson-check-all gets invoked.

For workshop-based repositories, we'd want to invoke make workshop-check. When it's the template itself, we could edit the index file to populate the yaml header to check the validity of the lesson (that's what we used to do on Travis CI).

It seems that we could create a new target in the Makefile (e.g., make check) that would look at the value of the kind : key in the _config.yml and depending on whether it's workshop or lesson would invoke make workshop-check or make lesson-check-all respectively so we could have a simpler GitHub actions file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant