Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Apprise general text conversion support #566

Merged
merged 9 commits into from
Apr 16, 2022

Conversation

caronc
Copy link
Owner

@caronc caronc commented Apr 10, 2022

Description:

Related issue (if applicable): #565

Greatly improved Telegram test cases to accommodate bug issue raised. Text Conversion enhanced to support titles.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in
# This way you can just destroy it after when it's all over.
# The below will create a directory called apprise
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@565-telegram-html-titles

# Run Telegram Tests
apprise telegram://credentials

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #566 (b6c968f) into master (b28cd4c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #566    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          107       107            
  Lines        13905     14416   +511     
  Branches      2600      2773   +173     
==========================================
+ Hits         13905     14416   +511     
Impacted Files Coverage Δ
apprise/Apprise.py 100.00% <100.00%> (ø)
apprise/AppriseAsset.py 100.00% <100.00%> (ø)
apprise/conversion.py 100.00% <100.00%> (ø)
apprise/plugins/NotifyTelegram.py 100.00% <100.00%> (ø)
apprise/utils.py 100.00% <0.00%> (ø)
apprise/common.py 100.00% <0.00%> (ø)
apprise/AppriseConfig.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28cd4c...b6c968f. Read the comment docs.

@caronc caronc merged commit a05b042 into master Apr 16, 2022
@caronc caronc deleted the 565-telegram-html-titles branch April 21, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants