Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Plugin Initialization Failures Should Be More Verbose #469

Open
caronc opened this issue Oct 25, 2021 · 0 comments
Open

Notification Plugin Initialization Failures Should Be More Verbose #469

caronc opened this issue Oct 25, 2021 · 0 comments

Comments

@caronc
Copy link
Owner

caronc commented Oct 25, 2021

💡 The Idea
With respect to a very good point brought forth in #460, Apprise isn't very verbose in the late stages of parsing a URL it supports. For example, if you pass in invalid://just-a-bad-apprise-query-in-general: you get an expected error that the URL could not be parsed.

However, if you successfully process a very valid URL that makes it all they way to the __init__() call of the very plugin in charge and it fails there (with a TypeError exception internally), the logging reason is only a WARNING.

A new standard needs to be in place where this changes to a ERROR type (for __init__ only) granting more information to the user calling an almost valid Apprise URL why it failed to be parsed.

Another consideration is privacy; logging information (with the exception of DEBUG) should not write anything into the logs that is privacy related. Error's that involve tokens or passwords in the __init__() should not write these tokens/passwords to the logs.

🔨 Breaking Feature
nothing will break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant