Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE7/IE8 javascript error #3

Open
marcovtwout opened this issue Feb 6, 2014 · 2 comments
Open

IE7/IE8 javascript error #3

marcovtwout opened this issue Feb 6, 2014 · 2 comments

Comments

@marcovtwout
Copy link

https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L151

Class is a reserved keyword. Replace by:

params.options["class"]
@marcovtwout
Copy link
Author

Even better: rename the keyword to something non-reserved, like "cssClass"

@carlsednaoui
Copy link
Owner

Good call!

I'll be reviewing this lib in the coming weeks. Let me know if you have any other feedback. Thanks @marcovtwout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcovtwout @carlsednaoui