From 1e944ec2f04ce3e59960d842acad207378ff5b39 Mon Sep 17 00:00:00 2001 From: Srikanth Chekuri Date: Mon, 21 Mar 2022 20:31:46 +0530 Subject: [PATCH] Remove `flush` method on LogEmitter (#2405) Fixes #2342 ## Changes This change proposes to remove the `flush` on Emitter for the consistency. There is no `flush` on Tracer/Meter specification. Language sdk implementations may choose the idiomatic way to provide the appender/handler ability to call flush on the `LogEmitterProvider` (ex: setter in [java](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/log4j/log4j-appender-2.16/library/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_16/OpenTelemetryAppender.java#L86-L95), `init` arg in py, or possibly a global accessor for provider etc...) --- CHANGELOG.md | 3 +++ specification/logs/logging-library-sdk.md | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0f0f49bf90f..ecd9a836c88 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,9 @@ release. ### Logs +- Remove `flush` method on LogEmitter + ([#2405](https://github.com/open-telemetry/opentelemetry-specification/pull/2405)) + ### Resource ### Semantic Conventions diff --git a/specification/logs/logging-library-sdk.md b/specification/logs/logging-library-sdk.md index 557c70fe07d..7ab6131c184 100644 --- a/specification/logs/logging-library-sdk.md +++ b/specification/logs/logging-library-sdk.md @@ -63,8 +63,6 @@ Methods: e.g. [Java discussion](https://github.com/open-telemetry/opentelemetry-java/pull/3759#discussion_r738019425)) -- Flush. - ### LogRecord See LogRecord [data model](data-model.md) for the list of fields.