Implement O(n) FromIterator<(usize, T)> and more iteration features #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why squash? Now a single commit implements 3+ orthogonal features, ugh. |
|
Habit mostly. Ideally separate features are in separate PRs. This keeps the link between commits & PR conversation. I opted to squash as I felt it was related enough to not merit asking to split up the PRs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FromIteratorimpl usesrecreate_vacant_list()from #60, so the first commit from there is included here too.I have not implemented
Extendbecause repairing the vacant list if the iterator panics is more trouble than its worth.cc #42
Edit:
I collected these commits into one PR because they would not apply independently, but please don't squash them as the commits add different features.
I'll rebase once
recreate_vacant_list()is on master.