-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize binstalk-{manifest, types} #610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug CI has shown that this PR indeed reduces the size of the binary. |
with features serde Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
to avoid cloning in `CrateSource::cratesio_registry` Signed-off-by: Jiahao XU <[email protected]>
to avoid cloning in `Source::cratesio_registry` and `impl From<&CrateSource> for Source`. Signed-off-by: Jiahao XU <[email protected]>
in `impl<'a> From<&'a CrateSource> for Source<'a>` Signed-off-by: Jiahao XU <[email protected]>
caused by `CrateVersionSource::from` by manually `format!` name, version and source into string. Signed-off-by: Jiahao XU <[email protected]>
with features impl_serde Signed-off-by: Jiahao XU <[email protected]>
Signed-off-by: Jiahao XU <[email protected]>
to speed up compilation and reduce bloat. Previously we switch to toml_edit because it is unmaintained, but now with it moved into toml-rs/toml as a workspace, it is now under active maintenance again, thus we switch back to it. Signed-off-by: Jiahao XU <[email protected]>
NobodyXu
force-pushed
the
optimize/avoid-cloning-in-manifest
branch
from
December 19, 2022 08:01
90eb5ed
to
3adc4a2
Compare
passcod
approved these changes
Dec 21, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new dep maybe-owned v0.3.4 to binstalk-types with features serde
Re-export maybe_owned in binstalk-types
Optimize
CrateSource::url
: UseMaybeOwned<'static, Url>
to avoid cloning in
CrateSource::cratesio_registry
Optimize
Source
: UseMaybeOwned<'static, Url>
to avoid cloning in
Source::cratesio_registry
andimpl From<&CrateSource> for Source
.Optimize
Source
: Add lifetime<'a>
to avoid cloningin
impl<'a> From<&'a CrateSource> for Source<'a>
Optimize
CratesToml::append_to_path
: Avoid cloningcaused by
CrateVersionSource::from
by manuallyformat!
name, versionand source into string.
Add new dep beef v0.5.2 to binstalk-manifests with features impl_serde
Optimize
CratesToml::append_to_path
: Eliminatemetadata.bins.clone()
by usingCow
Replace dep toml_edit with toml v0.5.10 in binstalk-manifests
to speed up compilation and reduce bloat.
Previously we switch to toml_edit because it is unmaintained, but now
with it moved into toml-rs/toml as a workspace, it is now under active
maintenance again, thus we switch back to it.
Signed-off-by: Jiahao XU [email protected]