Optimize CratesToml::append_to_path: Eliminate metadata.bins.clone()

Signed-off-by: Jiahao XU <[email protected]>

crates/binstalk-manifests/src/cargo_crates_v1.rs

@@ -15,6 +15,7 @@ use std::{
     path::{Path, PathBuf},
 };
 
+use beef::Cow;
 use compact_str::CompactString;
 use fs_lock::FileLock;
 use home::cargo_home;
@@ -31,12 +32,12 @@ mod crate_version_source;
 use crate_version_source::*;
 
 #[derive(Clone, Debug, Default, Deserialize, Serialize)]
-pub struct CratesToml {
+pub struct CratesToml<'a> {
     #[serde(with = "tuple_vec_map")]
-    v1: Vec<(String, Vec<CompactString>)>,
+    v1: Vec<(String, Cow<'a, [CompactString]>)>,
 }
 
-impl CratesToml {
+impl CratesToml<'_> {
     pub fn default_path() -> Result<PathBuf, CratesTomlParseError> {
         Ok(cargo_home()?.join(".crates.toml"))
     }
@@ -59,7 +60,7 @@ impl CratesToml {
     /// Only use it when you know that the crate is not in the manifest.
     /// Otherwise, you need to call [`CratesToml::remove`] first.
     pub fn insert(&mut self, cvs: &CrateVersionSource, bins: Vec<CompactString>) {
-        self.v1.push((cvs.to_string(), bins));
+        self.v1.push((cvs.to_string(), Cow::owned(bins)));
     }
 
     pub fn remove(&mut self, name: &str) {
@@ -115,7 +116,7 @@ impl CratesToml {
             c1.remove(name);
             c1.v1.push((
                 format!("{name} {version} ({source})"),
-                metadata.bins.clone(),
+                Cow::borrowed(&metadata.bins),
             ));
         }