re-organize and add few new integration tests for byron calculate/migrate #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
paweljakubas
approved these changes
Nov 8, 2019
KtorZ
approved these changes
Nov 9, 2019
| it "BYRON_MIGRATE_02 - \ | ||
| \migrating an empty wallet should fail." | ||
| it "BYRON_CALCULATE_02 - \ | ||
| \for empty wallet calculated fee is zero." |
There was a problem hiding this comment.
I'd say that this should really return a 403 Forbidden but 🤷♂️
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2019
989: re-organize and add few new integration tests for byron calculate/migrate r=KtorZ a=piotr-iohk # Issue Number #779 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [ ] I have re-organized a bit and added few new integration test cases for byron migration/fee calculation to match with https://docs.google.com/spreadsheets/d/1fadIA_j4nCd3FbylPo5J8K9Fy6tixSC2T9V3xHKuUvU # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Piotr Stachyra <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#779
Overview
Comments