Simplify NetworkLayer #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
force-pushed
the
rvl/12/review-network-layer
branch
from
2fbbd44 to
3dfd7e5
Compare
KtorZ
approved these changes
Mar 14, 2019
There was a problem hiding this comment.
LGTM. I've added a small change on the mapUntilError function, mostly modifying the type-signature to better reflect on what the function is doing. Since it discards the error and can never fail, it makes more sense to return a m [b] rather than a Except e m [b].
KtorZ
changed the base branch from
KtorZ/review-slotting-as-primitive
to
master
The docstring says it can never fail, so I've reflected that in the type signature too. We are actually discarding the error here, so let's be honest about it :p
KtorZ
force-pushed
the
rvl/12/review-network-layer
branch
from
3dfd7e5 to
1bfdbff
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12
Overview
This carries on with the simplifications from #60.
ReaderTin favour of passing theHttpBridgeas a function argument.newNetworkLayerfunctionServantErrorintoHttpBridgeError