Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3378] Bump node to 9.0.0 #4672

Merged
merged 8 commits into from
Jul 11, 2024
Merged

[ADP-3378] Bump node to 9.0.0 #4672

merged 8 commits into from
Jul 11, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 9, 2024 •
edited
Loading

  • Use node 9.0.0 in babbage and conway integration tests
  • Ship node 9.0.0 in the packages
  • Modify local-cluster to decide how to create the node configs based on the era
  • Fix e2e instructions to let them run on any build

ADP-3378

@paolino paolino added the Release label Jul 9, 2024
@paolino paolino self-assigned this Jul 9, 2024
@paolino paolino changed the base branch from master to anviking/bump-node-to-8.12 July 9, 2024 12:00
@Anviking Anviking force-pushed the anviking/bump-node-to-8.12 branch 5 times, most recently from c884616 to 6758721 Compare July 10, 2024 09:42
Base automatically changed from anviking/bump-node-to-8.12 to master July 10, 2024 10:58
@paolino paolino force-pushed the paolino/ADP-3378/bump-node-to-9.0.0 branch 4 times, most recently from a1533e2 to f56060c Compare July 10, 2024 14:30
@paolino paolino marked this pull request as ready for review July 10, 2024 14:48
@paolino paolino force-pushed the paolino/ADP-3378/bump-node-to-9.0.0 branch from 194f176 to 327d336 Compare July 11, 2024 07:25
@paolino paolino requested a review from Anviking July 11, 2024 07:25
Anviking
Anviking approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@paolino paolino enabled auto-merge July 11, 2024 08:31
@paolino paolino added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit 63cb535 Jul 11, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3378/bump-node-to-9.0.0 branch July 11, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

Assignees

@paolino paolino

Labels
Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @Anviking