[ADP-3378] Bump node to 8.12 #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
2 times, most recently
from
87997b6 to
8a7d8d4
Compare
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
from
2535586 to
f071494
Compare
Anviking
commented
Jul 9, 2024
Comment on lines
-81
to
-88
| TranslationLogicMissingInput inp -> | ||
| apiError err400 UnresolvedInputs | ||
| $ T.unwords | ||
| [ "The transaction I was given contains inputs I don't know" | ||
| , "about. Please ensure all foreign inputs are specified as " | ||
| , "part of the API request. The unknown input is:\n\n" | ||
| , T.pack $ show inp | ||
| ] |
There was a problem hiding this comment.
I think this is basically unreachable anyway.
Comment on lines
-108
to
-114
| apiError err400 TranslationByronTxOutInContext | ||
| $ T.unwords | ||
| [ "The transaction I was given contains a Byron-style TxOut" | ||
| , "which is not supported when executing Plutus scripts. " | ||
| , "The offending TxOut is:\n\n" | ||
| , T.pack $ show txOut | ||
| ] |
There was a problem hiding this comment.
This is not unreachable, but i'd question the worth of maintaining this error mapping now. I don't think anyone uses it.
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
from
f071494 to
affb8f5
Compare
Anviking
commented
Jul 9, 2024
| @@ -24,6 +24,7 @@ | |||
| {- HLINT ignore "Use camelCase" -} | |||
|
|
|||
| {-# OPTIONS_GHC -fno-warn-orphans #-} | |||
| {-# OPTIONS_GHC -fno-warn-deprecations #-} | |||
There was a problem hiding this comment.
Can be addressed in later PR IMO.
Anviking
commented
Jul 9, 2024
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
2 times, most recently
from
1f29ad3 to
96a4f97
Compare
Anviking
commented
Jul 9, 2024
| @@ -147,6 +147,7 @@ constructAddressFromIx role pTemplate dTemplate ix = | |||
| Nothing -> | |||
| createEnterpriseAddress pScript | |||
|
|
|||
| -- | NOTE: The roles 'DRep', 'CCCold', 'CCHot' are not supported. | |||
There was a problem hiding this comment.
Although, I think restricting the domain with a new type containing a subset of CA.Role should be fairly painless. May try...
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
from
96a4f97 to
1be0fb9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
3 times, most recently
from
ad8cc9f to
c884616
Compare
- Adjust versions of tree-diff, ansi-wl-pprint, bech32 - wip: fix compilation errors - Use cardano-addresses with optparse-applicative 0.18.1 - Compilation fixes in BalanceSepec - Fixes in `Cardano.Api.Gen` - fixes for balance-tx tests - Fix and simplify `ErrAssignReedemers` - Regenerate Wallet CLI goldens - fixup replaceCosignersWithVerKeys
…ers` Proper fix can go in another PR and task.
Anviking
force-pushed
the
anviking/bump-node-to-8.12
branch
from
c884616 to
6758721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Issue Number
ADP-3381