[ADP-3306] Make more HTTP API errors machine-readable.

[paweljakubas]

• Convert to machine-readable error: AssetNotPresent
• Convert to machine-readable error: OutputTokenBundleSizeExceedsLimit
• Convert to machine-readable error: OutputTokenQuantityExceedsLimit
• Convert to machine-readable error: TransactionAlreadyInLedger
• Convert to machine-readable error: WrongEncryptionPassphrase

Issue Number

ADP-3306

[jonathanknowles]

Hi @paweljakubas

Thanks for making this PR!

I have two general comments:

• Suggestion:
  Can we convert the error strings into constants (i.e., stop building interpolated error strings)? Now that we have JSON objects to carry the variable parts of the error, I think there's no need to repeat this information within the error strings.

  Example: [ADP-3306] Make more HTTP API errors machine-readable. #4622 (comment)

• Request:
  Within API error record types, can we replace the use of low-level types like Text and Natural with specialised types such as ApiT TokenPolicyId, ApiT TokenQuantity, ApiAnyAddress? The existing API error types all use specialised types.

  Example: [ADP-3306] Make more HTTP API errors machine-readable. #4622 (comment)

[jonathanknowles]

Can we replace this with ApiAnyAddress?

Suggested change

	:: !Text
	:: !ApiAnyAddress

[jonathanknowles]

LGTM! 👍🏻

I think it makes sense to defer making a decision on using a more dedicated type for the address fields for now. Switching to ApiAddress n, where n is a NetworkDiscriminant would require quite a few invasive changes.