Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3297] Support restoration mode in CLI #4488

Merged
merged 4 commits into from
Mar 11, 2024
Merged

[ADP-3297] Support restoration mode in CLI #4488

merged 4 commits into from
Mar 11, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Mar 8, 2024

  • Add support for restoration mode options in the CLI interface

ADP-3297

@paolino paolino added the ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG label Mar 8, 2024
@paolino paolino self-assigned this Mar 8, 2024
@paolino paolino force-pushed the paolino/ADP-3297/restoration-mode-in-CLI branch from 952ca49 to d4eb70e Compare March 8, 2024 09:08
paweljakubas
paweljakubas requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit test here https://github.com/cardano-foundation/cardano-wallet/blob/master/lib/unit/test/unit/Cardano/CLISpec.hs

@paolino paolino force-pushed the paolino/ADP-3297/restoration-mode-in-CLI branch 2 times, most recently from 1154cef to 81c5b1f Compare March 8, 2024 10:01
@paolino paolino force-pushed the paolino/ADP-3297/restoration-mode-in-CLI branch 2 times, most recently from 2d9783d to d2ef1f9 Compare March 8, 2024 12:06
paweljakubas
paweljakubas approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo doc comment

@paolino paolino force-pushed the paolino/ADP-106/change-create-wallet-API-to-support-restoration-date branch 4 times, most recently from b82fdad to 794b206 Compare March 11, 2024 14:49
@paolino paolino force-pushed the paolino/ADP-3297/restoration-mode-in-CLI branch from d2ef1f9 to 8114d7d Compare March 11, 2024 15:48
@paolino paolino merged commit 80c0763 into paolino/ADP-106/change-create-wallet-API-to-support-restoration-date Mar 11, 2024
2 of 3 checks passed
@paolino paolino deleted the paolino/ADP-3297/restoration-mode-in-CLI branch March 11, 2024 16:03
@HeinrichApfelmus HeinrichApfelmus mentioned this pull request Mar 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2024
@HeinrichApfelmus
[ADP-3297] Change CLI docs for wallet create from-recovery-phrase (#…
0b915c6 
…4516)

This pull request adapts for the documentation in `docs/` to reflect the
changes to the `wallet create from-recovery-phrase` command introduced
in #4488 .

### Issue Number

ADP-3297
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 28, 2024
docs: [ADP-3297] Change CLI docs for `wallet create from-recovery-phr…
7964262 
…ase` (#4516) This pull request adapts for the documentation in `docs/` to reflect the changes to the `wallet create from-recovery-phrase` command introduced in #4488 . ### Issue Number ADP-3297 Source commit: 0b915c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@HeinrichApfelmus HeinrichApfelmus Awaiting requested review from HeinrichApfelmus

Assignees

@paolino paolino

Labels
ADDING FEATURE Mark a PR as adding a new feature, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @paweljakubas