Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ledger types in constructors of Redeemer. #4241

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Use ledger types in constructors of Redeemer. #4241

merged 5 commits into from
Nov 16, 2023

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Nov 16, 2023 •
edited
Loading

Issue

ADP-3184

Description

This PR adjusts the Redeemer type so that its constructors use ledger types, thus eliminating usages of types from:

  • cardano-api;
  • cardano-wallet-primitive.

@jonathanknowles jonathanknowles self-assigned this Nov 16, 2023
Anviking
Anviking approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@jonathanknowles jonathanknowles added this pull request to the merge queue Nov 16, 2023
Merged via the queue into master with commit bf42709 Nov 16, 2023
3 checks passed
@jonathanknowles jonathanknowles deleted the jonathanknowles/revise-redeemer-type branch November 16, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anviking Anviking Anviking approved these changes

Assignees

@jonathanknowles jonathanknowles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanknowles @Anviking