Improve cluster setup reliability #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves responsibility away from the caller and to `withCluster` which knows how to best setup mir, ma, and pure ada funds. Sharing the default "all faucet funds from Test.Integration.Faucet" in one place would be nice, but is tricky to do with the current package splits.
- Add helper `extraClusterSetupUsingNode` - Ensure it's called in both Alonzo and Babbage - Move "pre-registered stake key" setup to said helper
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
paweljakubas
approved these changes
Aug 17, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 17, 2022
3444: Improve cluster setup reliability r=Anviking a=Anviking
- [x] Ensure only a single pool has started when we submit txs containing important cluster setup
- Avoids setup being rolled back, later causing integration test failures
- [x] See that it works
### Comments
<!-- Additional comments, links, or screenshots to attach, if any. -->
### Issue Number
<!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles.
Note: Jira issues of the form ADP- will be auto-linked. -->
ADP-2140
Co-authored-by: Johannes Lund <[email protected]>
|
Hm... seems no wallets are syncing and it's about to fail: I have seen this occasionally locally too in the past. I think it doesn't have anything to do with this PR, but I also don't understand the cause 🤔 |
|
bors r- |
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 17, 2022
3437: Bump version numbers for release of v2022-08-16 r=HeinrichApfelmus a=HeinrichApfelmus - [x] Bump dependencies to match `cardano-node` 1.35.3 - [x] Bump dependency on `cardano-addresses`. - [x] Bump `cardano-wallet` version number to `2022.8.16`. ### Comments In preparation for a release, this pull request bumps dependencies and the package version number. ### Issue Number ADP-1999 3444: Improve cluster setup reliability r=Anviking a=Anviking - [x] Ensure only a single pool has started when we submit txs containing important cluster setup - Avoids setup being rolled back, later causing integration test failures - [x] See that it works ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> ADP-2140 Co-authored-by: Heinrich Apfelmus <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Required status check \"docs\" is expected.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
Merging manually |
2 tasks
iohk-bors bot
added a commit
that referenced
this pull request
Aug 18, 2022
3446: Ensure withCluster can work with a single pool to fix latency bench r=Anviking a=Anviking
- [x] Ensure `launchPools []` doesn't fail with `Prelude.head: empty list`
- With #3444, we launch the `head` of the pools separately from `launchPools (tail pools)`, so the tail can be empty.
### Comments
- [x] Nightly latency step should succeed https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/1465
<!-- Additional comments, links, or screenshots to attach, if any. -->
### Issue Number
ADP-2147
Co-authored-by: Johannes Lund <[email protected]>
This was referenced Aug 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
Issue Number
ADP-2140