Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collateral outputs e2e testing #3367

Conversation

piotr-iohk
Copy link
Contributor

@piotr-iohk piotr-iohk commented Jun 29, 2022

  • I have added e2e test as defined in ADP-1969

Comments

This test verifies the fix for ADP-1970.
Currently it can be executed only against vasil-dev and is skipped when running on testnet.
Once testnet is HFed we will enable it there as well.

Issue Number

ADP-1969 / ADP-1970

@piotr-iohk piotr-iohk self-assigned this Jun 29, 2022
@piotr-iohk piotr-iohk mentioned this pull request Jun 29, 2022
2 tasks
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat test suite!

@piotr-iohk piotr-iohk merged commit 5d4bc65 into paweljakubas/adp-xxxx/fix-script-validity Jun 29, 2022
@piotr-iohk piotr-iohk deleted the piotr/collateral-inpts-outpts-e2e-testing branch June 29, 2022 15:13
iohk-bors bot added a commit that referenced this pull request Jun 29, 2022
3365: Fix script validity r=paweljakubas a=paweljakubas

## Issue Number
ADP-1970
ADP-1969

## Tasks

- [x] Make sure script validity is propagated upwards for Alonzo and Babbage (Pawel)
- [x] Add e2e tests showing proper collateral accounting and behaviour when script is invalid in the second phase validation (Piotr) -> in #3367

## Comments

Co-authored-by: Pawel Jakubas <[email protected]>
Co-authored-by: Piotr Stachyra <[email protected]>
Co-authored-by: piotr-iohk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants