use a patched openapi3 lib #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
lgtm! (assuming you've tested it locally) One nitpick: paolino/openapi3@0e94180#r71817634
paolino
force-pushed
the
paolino/ADP-1596/use-custom-openlib3
branch
from
d4f09f4 to
bec7900
Compare
paolino
force-pushed
the
paolino/ADP-1596/use-custom-openlib3
branch
from
bec7900 to
2125838
Compare
paolino
force-pushed
the
paolino/ADP-1596/use-custom-openlib3
branch
from
2125838 to
a76bc61
Compare
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make paolino a reviewer |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 25, 2022
3244: use a patched openapi3 lib r=jonathanknowles a=paolino - this is a separate PR just to update the git sources to use a modified openlib3 - stack and cabal are modified and in sync - a todo is added to a tech debt ticket to remind us to remove this change when the patch is absorbed - no use of anyOf is in the code, for now, it will become useful in the next PR ### Issue Number ADP-1596 Co-authored-by: Paolo Veronelli <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 25, 2022
3244: use a patched openapi3 lib r=Unisay a=paolino - this is a separate PR just to update the git sources to use a modified openlib3 - stack and cabal are modified and in sync - a todo is added to a tech debt ticket to remind us to remove this change when the patch is absorbed - no use of anyOf is in the code, for now, it will become useful in the next PR ### Issue Number ADP-1596 Co-authored-by: Paolo Veronelli <[email protected]>
|
Build failed: |
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make paolino a reviewer |
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make paolino a reviewer |
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make paolino a reviewer |
|
bors try |
|
🔒 Permission denied Existing reviewers: click here to make paolino a reviewer |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1596