Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in comments and function names. #3153

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix typos in comments and function names. #3153

merged 1 commit into from
Feb 25, 2022

Conversation

rex4539
Copy link
Contributor

@rex4539 rex4539 commented Feb 23, 2022

No description provided.

Copy link
Member

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rex4539

Many thanks for making this PR! It's really helpful.

I've added a couple of suggestions. I wonder if you can apply them?

If so, would be very happy to merge this.

Many thanks again!

lib/core/src/Network/Ntp.hs Show resolved Hide resolved
@jonathanknowles jonathanknowles changed the title Fix typos Fix typos in comments and function names. Feb 23, 2022
Copy link
Member

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rex4539

This looks great!

Many thanks again for your PR. ❤️

@jonathanknowles
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 23, 2022
3153: Fix typos in comments and function names. r=jonathanknowles a=rex4539



Co-authored-by: Dimitris Apostolou <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 23, 2022

Build failed:

@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 23, 2022
3153: Fix typos in comments and function names. r=Anviking a=rex4539



Co-authored-by: Dimitris Apostolou <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 23, 2022

Build failed:

src/Test/Integration/Scenario/CLI/Shelley/Transactions.hs:244:59:
--
  | 1) CLI Specifications, SHELLEY_CLI_TRANSACTIONS, TRANS_CREATE_06 - Invalid amount, string with diacritics
  | uncaught exception: IOException of type ResourceVanished
  | fd:98: hFlush: resource vanished (Broken pipe)

#2855

@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 24, 2022
3153: Fix typos in comments and function names. r=Anviking a=rex4539



Co-authored-by: Dimitris Apostolou <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 24, 2022

Build failed:

nix develop .#cabal --command scripts/buildkite/cabal-ci.sh configure
--
  | warning: Git tree '/var/lib/buildkite-agent-iohk/builds/packet-ipxe-2-ci2-1/input-output-hk/cardano-wallet' is dirty
  | Updating Hackage index | 0s
  | Downloading the latest package list from hackage.haskell.org
  | cabal: Could not read index. Did you call 'checkForUpdates'?
  | 🚨 Error: The command exited with status 1
  | user command error: exit status 1

@rex4539
Copy link
Contributor Author

rex4539 commented Feb 24, 2022

As I don't have access to bors and buildkite, if someone could point what exactly is failing, I could try to fix it in the blind.

@Anviking
Copy link
Member

@rex4539 the failures are not related to this PR, but to CI and/or flaky tests. We'll get it merged; thanks!

The most recent issue (which just has appeared on multiple PRs) is

nix develop .#cabal --command scripts/buildkite/cabal-ci.sh configure
--
  | warning: Git tree '/var/lib/buildkite-agent-iohk/builds/packet-ipxe-2-ci2-1/input-output-hk/cardano-wallet' is dirty
  | Updating Hackage index | 0s
  | Downloading the latest package list from hackage.haskell.org
  | cabal: Could not read index. Did you call 'checkForUpdates'?
  | 🚨 Error: The command exited with status 1
  | user command error: exit status 1

which seems like haskell/cabal#5574, so possibly @rvl need to clear the caches again…

@Anviking Anviking enabled auto-merge (rebase) February 24, 2022 18:29
@Anviking
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 25, 2022
3153: Fix typos in comments and function names. r=Anviking a=rex4539



Co-authored-by: Dimitris Apostolou <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 25, 2022

Build failed:

src/Test/Integration/Scenario/API/Shelley/TransactionsNew.hs:2116:54:
--
  | 1) API Specifications, NEW_SHELLEY_TRANSACTIONS, Plutus scenarios, withdrawal
  | uncaught exception: ProcessHasExited
  | ProcessHasExited "cardano-cli failed: Command failed: transaction submit  Error: Error while submitting tx: ShelleyTxValidationError ShelleyBasedEraAlonzo (ApplyTxError [DelegsFailure (DelplFailure (DelegFailure (StakeKeyAlreadyRegisteredDELEG (ScriptHashObj (ScriptHash \"1b8374d0b294a4a3399ff25f06a0707b16214f1e9b67cf89ba2454a6\")))))])\n" (ExitFailure 1)

#3057

@Anviking
Copy link
Member

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 25, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit bd8a530 into cardano-foundation:master Feb 25, 2022
WilliamKingNoel-Bot pushed a commit that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants