-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos in comments and function names. #3153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rex4539
Many thanks for making this PR! It's really helpful.
I've added a couple of suggestions. I wonder if you can apply them?
If so, would be very happy to merge this.
Many thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+ |
3153: Fix typos in comments and function names. r=jonathanknowles a=rex4539 Co-authored-by: Dimitris Apostolou <[email protected]>
Build failed: |
bors r+ |
3153: Fix typos in comments and function names. r=Anviking a=rex4539 Co-authored-by: Dimitris Apostolou <[email protected]>
Build failed:
|
bors r+ |
3153: Fix typos in comments and function names. r=Anviking a=rex4539 Co-authored-by: Dimitris Apostolou <[email protected]>
Build failed:
|
As I don't have access to bors and buildkite, if someone could point what exactly is failing, I could try to fix it in the blind. |
@rex4539 the failures are not related to this PR, but to CI and/or flaky tests. We'll get it merged; thanks! The most recent issue (which just has appeared on multiple PRs) is nix develop .#cabal --command scripts/buildkite/cabal-ci.sh configure
--
| warning: Git tree '/var/lib/buildkite-agent-iohk/builds/packet-ipxe-2-ci2-1/input-output-hk/cardano-wallet' is dirty
| Updating Hackage index | 0s
| Downloading the latest package list from hackage.haskell.org
| cabal: Could not read index. Did you call 'checkForUpdates'?
| 🚨 Error: The command exited with status 1
| user command error: exit status 1
which seems like haskell/cabal#5574, so possibly @rvl need to clear the caches again… |
bors r+ |
3153: Fix typos in comments and function names. r=Anviking a=rex4539 Co-authored-by: Dimitris Apostolou <[email protected]>
Build failed:
|
bors r+ |
Build succeeded: |
No description provided.