E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) #2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncluding purpose)
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 9, 2021
2697: E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) r=piotr-iohk a=piotr-iohk # Issue Number ADP-950 # Overview - 0ded5ef E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) # Comments While testing purpose addition to https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postAccountKey endpoint I have extended existing e2e tests to assert if the returned keys are the same as produced by cardano-addresses. Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed: #2472 (mac-mini-2) |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 9, 2021
2697: E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) r=piotr-iohk a=piotr-iohk # Issue Number ADP-950 # Overview - 0ded5ef E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) # Comments While testing purpose addition to https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postAccountKey endpoint I have extended existing e2e tests to assert if the returned keys are the same as produced by cardano-addresses. Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed: #2472 (mac-mini-1) |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 10, 2021
2696: Timeout earlier on SQLITE_BUSY when deleting wallets in tests r=rvl a=Anviking # Issue Number ADP-827 # Overview - [x] Set `CARDANO_WALLET_INTEGRATION` env var in integration tests - [x] Change timeout to close all connections from `60s` to `2s` if `CARDANO_WALLET_INTEGRATION` is set. # Comments - Workaround that should make CI faster (and perhaps a bit more stable), until we have time to investigate and address the underlying issue and its effects in production. The problem in production is likely much less serious, as users likely don't create and delete wallets as often as in our integration tests. - Locally, running `stack test cardano-wallet:integration --ta '-j 6'` I get: - 2s -> 335s - 5s -> 380s - 60s (without the `setEnv`) -> 1190s So that's why I went with 2s rather than 5s. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> 2697: E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) r=rvl a=piotr-iohk # Issue Number ADP-950 # Overview - 0ded5ef E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose) # Comments While testing purpose addition to https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postAccountKey endpoint I have extended existing e2e tests to assert if the returned keys are the same as produced by cardano-addresses. Co-authored-by: Johannes Lund <[email protected]> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-950
Overview
E2E golden tests cardano-wallet vs. cardano-addresses account xpub (including purpose)
Comments
While testing purpose addition to https://input-output-hk.github.io/cardano-wallet/api/edge/#operation/postAccountKey endpoint I have extended existing e2e tests to assert if the returned keys are the same as produced by cardano-addresses.