Fix massive memory leak in unit tests #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
changed the title
Anviking
commented
Feb 25, 2021
Anviking
force-pushed
the
anviking/ADP-747/test-generators
branch
2 times, most recently
from
015f86f to
03cde55
Compare
Instead of consuming 10s of GB, we the unit tests only consumes 50 MB at most. Hopefully this will fix the CI unit test timeouts.
Anviking
force-pushed
the
anviking/ADP-747/test-generators
branch
from
03cde55 to
67f3e6f
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 26, 2021
2537: Fix massive memory leak in unit tests r=Anviking a=Anviking # Issue Number ADP-758, #2472 # Overview - [x] Make sure to also close the DBLayers we create! - [x] <s>Use validateGenerator to also test non-QSM Arbitrary instances</s> - [ ] <s>TODO: Look a bit more at the generators / validation of them, could perhaps split the PR too.</s> # Comments Before this fix the memory usage would steadily climb upwards 5-15GB. Now it's at most ~40 MB. ### Running part of unit tests before fix: <img width="1167" alt="ska__rmavbild_2021-02-25_kl _12 34 43" src="https://user-images.githubusercontent.com/304423/109172195-cafd8c00-7782-11eb-8afd-a40732fccded.png"> ### Running all unit tests after fix: <img width="1399" alt="Skärmavbild 2021-02-25 kl 15 54 16" src="https://user-images.githubusercontent.com/304423/109171975-938edf80-7782-11eb-904b-9404708fbdde.png"> <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket ✓ Acknowledge any changes required to the Wiki ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. --> Co-authored-by: Johannes Lund <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-758, #2472
Overview
Use validateGenerator to also test non-QSM Arbitrary instancesTODO: Look a bit more at the generators / validation of them, could perhaps split the PR too.Comments
Before this fix the memory usage would steadily climb upwards 5-15GB. Now it's at most ~40 MB.
Running part of unit tests before fix:
Running all unit tests after fix: