Update docker-compose from make_release.sh #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
added
the
IMPROVEMENT
rvl
approved these changes
Dec 18, 2020
scripts/make_release.sh
Outdated
| @@ -38,11 +38,15 @@ WIKI_COMMIT=$(git ls-remote https://github.com/$REPO.wiki.git HEAD | cut -f1) | |||
| echo "" | |||
| echo "Replacing $OLD_CABAL_VERSION with $CABAL_VERSION" | |||
| sed -i "s/$OLD_CABAL_VERSION/$CABAL_VERSION/" \ | |||
| $(git ls-files '*.nix:!:nix/migration-tests.nix'; git ls-files '*.cabal'; git ls-files '*swagger.yaml') | |||
| $(git ls-files '*.nix:!:nix/migration-tests.nix'; git ls-files '*.cabal'; git ls-files '*swagger.yaml'; git ls-files 'docker-compose.yml') | |||
There was a problem hiding this comment.
Suggested change
| $(git ls-files '*.nix:!:nix/migration-tests.nix'; git ls-files '*.cabal'; git ls-files '*swagger.yaml'; git ls-files 'docker-compose.yml') | |
| $(git ls-files '*.nix:!:nix/migration-tests.nix'; git ls-files '*.cabal'; git ls-files '*swagger.yaml') docker-compose.yml |
scripts/make_release.sh
Outdated
| echo "Looking for remaining references to old version:" | ||
| git grep $OLD_CABAL_VERSION | ||
| echo "" | ||
|
|
||
| echo "Updating docker-compose.yml with $CARDANO_NODE_TAG cardano-node tag" | ||
| sed -i "s/$OLD_CARDANO_NODE_TAG/$CARDANO_NODE_TAG/" docker-compose.yml |
There was a problem hiding this comment.
This way you don't need the old tag -
Suggested change
| sed -i "s/$OLD_CARDANO_NODE_TAG/$CARDANO_NODE_TAG/" docker-compose.yml | |
| sed -i "s|inputoutput/cardano-node:.*|inputoutput/cardano-node:$CARDANO_NODE_TAG|" docker-compose.yml |
piotr-iohk
force-pushed
the
piotr/update-docker-compose-on-release
branch
from
e02d604 to
5fed606
Compare
piotr-iohk
force-pushed
the
piotr/update-docker-compose-on-release
branch
from
5fed606 to
058bc14
Compare
|
Thanks @rvl. Fixed. |
|
bors r+ |
KtorZ
approved these changes
Dec 18, 2020
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2398
Overview
Update docker-compose from make_release.sh
Comments