Fix parsing of SMASHPoolId

[hasufell]

follow-up fix of #2249

found by @piotr-iohk

https://smash.shelley-qa.dev.cardano.org/api/v1/delisted vs https://smash.cardano-mainnet.iohk.io/api/v1/delisted

[piotr-iohk]

OK, works fine on shelley_qa (bech32 delsited pool_ids) and testnet/mainnet (hex-encoded delisted pool_ids).

[hasufell]

bors r+

[iohk-bors]

Build failed:

• buildkite/cardano-wallet

--
  | src/Test/Integration/Scenario/API/Shelley/StakePools.hs:551:5:
  | 1) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_JOIN_05 - Can join when stake key already exists
  | uncaught exception: RequestException
  | DecodeFailure "{\"code\":\"network_unreachable\",\"message\":\"The node backend is unreachable at the moment. Trying again in a bit might work.\"}"
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_JOIN_05 - Can join when stake key already exists/"
  |  
  | Randomized with seed 800005585

#2230

[hasufell]

bors r+

[iohk-bors]

Build failed:

• ci/hydra-build:required

It says timed out, although the last printed lines don't seem like a timeout:

    correct time measures
      # PENDING: Disabled on windows due to race with log flushing

Finished in 689.3699 seconds
2363 examples, 0 failures, 6 pending
================================================================================
END RUNNING TESTS
================================================================================

[hasufell]

bors r+

[iohk-bors]

Build failed:

• buildkite/cardano-wallet

src/Test/Integration/Scenario/API/Shelley/Transactions.hs:642:10:
--
  | 1) API Specifications, SHELLEY_TRANSACTIONS, TRANS_TTL_01 - Pending transaction expiry
  | predicate failed on: SlotNo 72
  | expected expiry: SlotNo 37530
  | actual expiry: SlotNo 37602
  |  
  | To rerun use: --match "/API Specifications/SHELLEY_TRANSACTIONS/TRANS_TTL_01 - Pending transaction expiry/"
  |  

#2295

[hasufell]

bors r+

[iohk-bors]

Build failed:

• ci/hydra-build:required

  src/Test/Integration/Scenario/API/Byron/Migrations.hs:306:19:
  1) API Specifications, BYRON_MIGRATIONS, BYRON_MIGRATE_01 -  migrate a big wallet requiring more than one tx
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right (ApiUtxoStatistics {total = Quantity {getQuantity = 939993308496}, scale = ApiT {getApiT = Log10}, distribution = fromList [(10,0),(100,0),(1000,0),(10000,0),(100000,0),(1000000,0),(10000000,0),(100000000,0),(1000000000,0),(10000000000,94),(100000000000,0),(1000000000000,0),(10000000000000,0),(100000000000000,0),(1000000000000000,0),(10000000000000000,0),(45000000000000000,0)]}))
       expected: Just 100
        but got: Just 94

  To rerun use: --match "/API Specifications/BYRON_MIGRATIONS/BYRON_MIGRATE_01 -  migrate a big wallet requiring more than one tx/"

  src/Test/Integration/Framework/DSL.hs:670:11:
  2) API Specifications, SHELLEY_STAKE_POOLS, STAKE_POOLS_LIST_01 - List stake pools, has non-zero saturation & stake
       Quantity {getQuantity = Percentage {getPercentage = 0 % 1}} does not satisfy (> Quantity {getQuantity = Percentage {getPercentage = 0 % 1}})
       While verifying (Status {statusCode = 200, statusMessage = "OK"},Right [ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\ESC=\193\156j\184\158\175\252\133\SOH\243u\187\ETX\193\ESC\248\237]\CAN76\177\216\EOT\DC3\214"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 17637618718731848}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 3 % 5000}}, saturation = 1.8839505290334695e-3, producedBlocks = Quantity {getQuantity = 252}}, metadata = Just (ApiT {getApiT = StakePoolMetadata {ticker = StakePoolTicker {unStakePoolTicker = "GPB"}, name = "Genesis Pool B", description = Nothing, homepage = "https://iohk.io"}}), cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 2000000000000}, retirement = Nothing, flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\236(\243=\203\230\214@\n\RS^3\155\208d|\ts\202l\f\249\194\187\230\131\141\198"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 16667484355748775}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 1 % 2500}}, saturation = 1.150133619690934e-3, producedBlocks = Quantity {getQuantity = 155}}, metadata = Just (ApiT {getApiT = StakePoolMetadata {ticker = StakePoolTicker {unStakePoolTicker = "GPA"}, name = "Genesis Pool A", description = Nothing, homepage = "https://iohk.io"}}), cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 1000000}}, epochStartTime = 2022-02-16 20:04:30 UTC}), flags = []},ApiStakePool {id = ApiT {getApiT = PoolId {getPoolId = "\187\DC1L\179}u\250\ENQ&\ETX(\194\&5\163\218\226\149\163=\v\166t\165\235\RS>V\142"}}, metrics = ApiStakePoolMetrics {nonMyopicMemberRewards = Quantity {getQuantity = 13669100926672274}, relativeStake = Quantity {getQuantity = Percentage {getPercentage = 0 % 1}}, saturation = 3.919830222887316e-5, producedBlocks = Quantity {getQuantity = 0}}, metadata = Just (ApiT {getApiT = StakePoolMetadata {ticker = StakePoolTicker {unStakePoolTicker = "GPD"}, name = "Genesis Pool D", description = Just "Lorem Ipsum Dolor Sit Amet.", homepage = "https://iohk.io"}}), cost = Quantity {getQuantity = 0}, margin = Quantity {getQuantity = Percentage {getPercentage = 1 % 10}}, pledge = Quantity {getQuantity = 1000000000000}, retirement = Just (ApiEpochInfo {epochNumber = ApiT {getApiT = EpochNo {unEpochNo = 100000}}, epochStartTime = 2020-12-27 04:04:30 UTC}), flags = []}])
       Waited longer than 90s to resolve action: "list pools returns non-empty list".

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_LIST_01 - List stake pools/has non-zero saturation & stake/"

on Mac mini

#BYRON_MIGRATE_01

#2224

[hasufell]

bors r+

[iohk-bors]

Build failed:

• buildkite/cardano-wallet

cardano-wallet-2020.11.3: test (suite: unit, args: --jobs 8)
--
  | cardano-wallet-2020.11.3: Test suite unit passed
  | Progress 6/7: cardano-wallet-core-2020.11.3
  | Timed out after 60 minutes.

Cardano.Wallet.DB.MVar
  MVar
    Extra Properties about DB initialization
      createWallet . listWallets yields expected results
        +++ OK, passed 100 tests.
      creating same wallet twice yields an error
        +++ OK, passed 100 tests.
      removing the same wallet twice yields an error
        +++ OK, passed 100 tests.
    put . read yields a result
      Checkpoint

#2292

[hasufell]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet
• ci/hydra-build:required