Increase bors timeout from 2h to 4h #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
approved these changes
Nov 2, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 2, 2020
2262: Allow deleting expired transactions from the API r=rvl a=rvl ### Issue Number ADP-93 / #1840 ### Overview - [x] Using the existing transaction delete endpoint, also permit removing expired transactions. - [x] Simplify DB model and state machine tests for this function - [x] Integration test ### Comments - Based on PR #2167 branch - merge that first. 2282: Increase bors timeout from 2h to 3h r=Anviking a=Anviking # Issue Number #2279 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Increase bors timeout from 2h to 3h # Comments It seems hydra is often slow to schedule/run the jobs, causing ≈18% of bors r+ to fail. It should be better to increase the timeout to 3h, than to have it fail. This doesn't affect the timeout of buildkite or hydra themselves. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Johannes Lund <[email protected]>
|
Build failed (retrying...): 👆 wat? It's a mistake in #2262 ... and also a change in master branch which needs to be accommodated for. |
|
bors r+ |
|
Already running a review |
|
bors r+ |
|
Already running a review |
|
bors r- |
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 2, 2020
2282: Increase bors timeout from 2h to 3h r=Anviking a=Anviking # Issue Number #2279 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Increase bors timeout from 2h to 3h # Comments It seems hydra is often slow to schedule/run the jobs, causing ≈18% of bors r+ to fail. It should be better to increase the timeout to 3h, than to have it fail. This doesn't affect the timeout of buildkite or hydra themselves. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
|
bors r- |
|
Canceled. |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 2, 2020
2282: Increase bors timeout from 2h to 3h r=KtorZ a=Anviking # Issue Number #2279 # Overview <!-- Detail in a few bullet points the work accomplished in this PR --> - [x] Increase bors timeout from 2h to 3h # Comments It seems hydra is often slow to schedule/run the jobs, causing ≈18% of bors r+ to fail. It should be better to increase the timeout to 3h, than to have it fail. This doesn't affect the timeout of buildkite or hydra themselves. <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Johannes Lund <[email protected]>
|
Timed out. |
It seems hydra is often slow to schedule/run the jobs. (≈18% of bors r+ it seems) It should be better to increase the timeout to 4h, than to have it fail. This doesn't affect the timeout of buildkite or hydra themselves. 3h didn't seem enough...
Anviking
force-pushed
the
anviking/bors-timeout
branch
from
bc9e214 to
d6b7627
Compare
|
I guess we'll do 4h instead 🤷♂️ In the above build, two hydra jobs are still building after 3h and 20 min. And done after 3h and 35m |
Anviking
changed the title
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#2279
Overview
Comments
It seems hydra is often slow to schedule/run the jobs, causing ≈18% of bors r+ to fail.
It should be better to increase the timeout to 3h, than to have it fail.
This doesn't affect the timeout of buildkite or hydra themselves.