Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fallback for metadata JSON parsing from pre-existing database #2173

Merged
merged 1 commit into from
Sep 24, 2020
Merged

add fallback for metadata JSON parsing from pre-existing database #2173

merged 1 commit into from
Sep 24, 2020

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Sep 24, 2020

Issue Number

#2172

Overview

  • I have added a fallback when deserializing from db

Comments

This is NOT 100% safe and it assumes that pre-existing metadata that were serialized with the 'direct' format does not parse with the 'detailed' format. This is however a reasonable assumption to make provided that we only released that for a single week and the number of users was fairly limited.

@KtorZ
add fallback for metadata JSON parsing from pre-existing database
d8eb645 
  This is NOT 100% safe and it assumes that pre-existing metadata that were serialized with the 'direct' format does not parse with the 'detailed' format. This is however a reasonable assumption to make provided that we only released that for a single week and the number of users was fairly limited.
@KtorZ KtorZ added the RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG label Sep 24, 2020
@KtorZ KtorZ requested review from rvl and piotr-iohk September 24, 2020 07:39
@KtorZ KtorZ self-assigned this Sep 24, 2020
piotr-iohk
piotr-iohk approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Checked against few wallets with old metadata on testnet and works fine.

@KtorZ
Copy link
Member Author

KtorZ commented Sep 24, 2020

bors try

iohk-bors bot added a commit that referenced this pull request Sep 24, 2020
@iohk-bors
Try #2173:
df44a1a
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 24, 2020

try

Build succeeded:

@KtorZ KtorZ merged commit e3145b8 into master Sep 24, 2020
@KtorZ KtorZ deleted the KtorZ/already-existing-metadata-fixup branch September 24, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees

@KtorZ KtorZ

Labels
RESOLVING ISSUE Mark a PR as resolving issues, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @piotr-iohk