Fix dylib references of bundled programs on macOS #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
added
the
RESOLVING ISSUE
rvl
force-pushed
the
rvl/2134/fix-macos-bundle
branch
from
af99d54 to
e25ba1f
Compare
piotr-iohk
reviewed
Sep 14, 2020
|
|
||
| tests[wallet].each do |cmd| | ||
| tests[wallet].unshift(wallet).each do |cmd| |
There was a problem hiding this comment.
My first ruby program 🙂
rvl
force-pushed
the
rvl/2134/fix-macos-bundle
branch
from
f9a9720 to
3e4a4ac
Compare
Looks like there is some issue in iohk-nix, and they aren't getting statically built on linux any more.
rvl
force-pushed
the
rvl/2134/fix-macos-bundle
branch
from
9530a0e to
e43dace
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 16, 2020
2135: Fix dylib references of bundled programs on macOS r=rvl a=rvl ### Issue Number Resolves #2134 ### Overview - On macOS rewrite dylib references from `/nix/store` to `@executable_path` - for every executable in the bundle. - Add linking tests to `check-bundle.rb` for macOS and Linux. Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: https://hydra.iohk.io/build/4137204/nixlog/1/tail Extract from log: Failures:
src/Test/Integration/Scenario/API/Shelley/Wallets.hs:467:23:
1) API Specifications, SHELLEY_WALLETS, WALLETS_CREATE_08 - address_pool_gap, 100000
expected: Status {statusCode = 201, statusMessage = "Created"}
but got: Status {statusCode = 409, statusMessage = "Conflict"}
from the following response: Left (DecodeFailure "Error in $: parsing Cardano.Wallet.Api.Types.ApiWallet(ApiWallet) failed, key \"id\" not found: Response {responseStatus = Status {statusCode = 409, statusMessage = \"Conflict\"}, responseVersion = HTTP/1.1, responseHeaders = [(\"Transfer-Encoding\",\"chunked\"),(\"Date\",\"Wed, 16 Sep 2020 07:19:28 GMT\"),(\"Server\",\"Warp/3.3.5\")], responseBody = \"{\\\"code\\\":\\\"wallet_already_exists\\\",\\\"message\\\":\\\"This operation would yield a wallet with the following id: a6b6625cd2bfc51a296b0933f77020991cc80374 However, I already know of a wallet with this id.\\\"}\", responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}")
To rerun use: --match "/API Specifications/SHELLEY_WALLETS/WALLETS_CREATE_08 - address_pool_gap/100000/" |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 17, 2020
2125: CLI: Add option "cardano-wallet transaction create --metadata=JSON" r=rvl a=rvl ### Issue Number ADP-307 / #2076 ### Overview - Adds `--metadata=JSON` option to transaction create and fee estimate commands. ### Comments Will update the CLI wiki page after merging. 2135: Fix dylib references of bundled programs on macOS r=rvl a=rvl ### Issue Number Resolves #2134 ### Overview - On macOS rewrite dylib references from `/nix/store` to `@executable_path` - for every executable in the bundle. - Add linking tests to `check-bundle.rb` for macOS and Linux. 2141: Make Jörmungandr tests pass again r=rvl a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview - 3665332 Disable STAKE_POOLS_* tests due to #2140 - 6e276af Remove hard-coded mnemonics in case not necessary in integration tests - 038c365 Remove Shelley specific transaction suite. Add few more basic transaction tests to Jormungandr suite. - 6e98d4b BYRON_MIGRATE_01 - make Jormungandr big wallet for migration smaller (the same as Shelley one) and adjust to pass on both backends - e3d6a55 adjust genMnemonics to be more standard # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 17, 2020
2135: Fix dylib references of bundled programs on macOS r=rvl a=rvl ### Issue Number Resolves #2134 ### Overview - On macOS rewrite dylib references from `/nix/store` to `@executable_path` - for every executable in the bundle. - Add linking tests to `check-bundle.rb` for macOS and Linux. 2141: Make Jörmungandr tests pass again r=rvl a=piotr-iohk # Issue Number <!-- Put here a reference to the issue this PR relates to and which requirements it tackles --> # Overview - 3665332 Disable STAKE_POOLS_* tests due to #2140 - 6e276af Remove hard-coded mnemonics in case not necessary in integration tests - 038c365 Remove Shelley specific transaction suite. Add few more basic transaction tests to Jormungandr suite. - 6e98d4b BYRON_MIGRATE_01 - make Jormungandr big wallet for migration smaller (the same as Shelley one) and adjust to pass on both backends - e3d6a55 adjust genMnemonics to be more standard # Comments <!-- Additional comments or screenshots to attach if any --> <!-- Don't forget to: ✓ Self-review your changes to make sure nothing unexpected slipped through ✓ Assign yourself to the PR ✓ Assign one or several reviewer(s) ✓ Once created, link this PR to its corresponding ticket ✓ Assign the PR to a corresponding milestone ✓ Acknowledge any changes required to the Wiki --> Co-authored-by: Rodney Lorrimar <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]>
|
Build failed (retrying...): |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 17, 2020
2135: Fix dylib references of bundled programs on macOS r=rvl a=rvl ### Issue Number Resolves #2134 ### Overview - On macOS rewrite dylib references from `/nix/store` to `@executable_path` - for every executable in the bundle. - Add linking tests to `check-bundle.rb` for macOS and Linux. Co-authored-by: Rodney Lorrimar <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Resolves #2134
Overview
/nix/storeto@executable_path- for every executable in the bundle.check-bundle.rbfor macOS and Linux.