Adjust travis deployment for renamed cardano-wallet binary #2048
Conversation
Anviking
changed the title
Anviking
added
the
IMPROVEMENT
| @@ -54,26 +54,11 @@ jobs: | |||
| ############################ | |||
|
|
|||
| # Fetch the linux archive | |||
| - travis_retry curl -L https://hydra.iohk.io/job/Cardano/cardano-wallet/cardano-wallet-linux64/latest/download/1 | tar xz | |||
| - find . -maxdepth 1 -type d -name "cardano-wallet-*" -exec mv \{} cardano-wallet-linux64 \; | |||
There was a problem hiding this comment.
cardano-wallet-* wouldn't match cardano-wallet.
|
I think the travis script needed to do some renaming and cleanup. Some filenames from Hydra were not right for example. But perhaps that could be fixed. I also added a script for downloading builds for the tagged version, rather than just latest master. This can be used instead of the |
I believe it was only used to rename the
💯 🙏 |
This should maintain exactly the same conventions as in previous releases, except that the byron/shelley split is gone. I have tested it by copying and pasting commands from the yaml into a temporary bash script file.
|
I made it follow naming conventions from previous releases (except for the byron/shelley split). And I have tested it by copying and pasting commands from bors r+ |
Build succeeded |
Issue Number
#1919
Overview
cardano-wallet-shelleytocardano-walletSimply use the archives from hydra as-is. No need to unzip an re-zip. We don't rename the executable anymore.@rvl has made it use same filenames as previous releases.Comments
Comparing latest release to manually calling
curl -L https://hydra.iohk.io/job/Cardano/cardano-wallet/cardano-wallet-linux64/latest/download/1 --output cardano-wallet-$TRAVIS_TAG-linux64.tar.gzThe extracted folder appears different. Does that matter?