Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new warnings in HLint v3.1.6 #1877

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Fix new warnings in HLint v3.1.6 #1877

merged 2 commits into from
Jul 8, 2020

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 8, 2020

Overview

HLint v3.1.6 can find more unused language extensions.

Comments

CI version update in PR #1857.

@rvl rvl requested a review from jonathanknowles July 8, 2020 01:07
@rvl rvl self-assigned this Jul 8, 2020
@rvl rvl mentioned this pull request Jul 8, 2020
@rvl
Copy link
Contributor Author

rvl commented Jul 8, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 8, 2020
1877: Fix new warnings in HLint v3.1.6 r=rvl a=rvl

### Overview

HLint v3.1.6 can find more unused language extensions.

### Comments

CI version update in PR #1857.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2020

Build failed

@jonathanknowles
Copy link
Member

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 8, 2020
1877: Fix new warnings in HLint v3.1.6 r=jonathanknowles a=rvl

### Overview

HLint v3.1.6 can find more unused language extensions.

### Comments

CI version update in PR #1857.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2020

Build failed

@Anviking
Copy link
Member

Anviking commented Jul 8, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 8, 2020
1875: Move sync progress logic to new module r=Anviking a=Anviking

# Issue Number

#1869 

# Overview

- [x] Make the sync progress logic easier to grasp by moving it to its own module
- [x] Add a note about the calculation going to break in era-transitions


# Comments

- I believe we may have to have to provide _several_ methods of calculating the sync-progress. Maybe we need a different one for jormungandr. I think a new module is neat regardless.

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


1877: Fix new warnings in HLint v3.1.6 r=Anviking a=rvl

### Overview

HLint v3.1.6 can find more unused language extensions.

### Comments

CI version update in PR #1857.


Co-authored-by: Johannes Lund <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2020

Build failed (retrying...)

iohk-bors bot added a commit that referenced this pull request Jul 8, 2020
1865: withdrawals as part of the coin selection r=KtorZ a=KtorZ

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->

#1861 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- 12b28f7
  📍 **take withdrawals into account, one level earlier, during the coin selection**
  Still to be done:

    - Make sure it's correctly done in the largest-first algorithm
    - Add some test scenario that show the influence of the withdrawal

- 547b130
  📍 **unit-test the newly introduced 'proportionallyTo'**
  Getting this one wrong would be quite bad :s

- 975f726
  📍 **add unit tests showing how withdrawal impacts the random coin selection**


> 💡 NOTE
>
> I've chosen not to treat the withdrawal as a single _input_, but more as a "money pot" that is proportionally distributed amongst change output, so that it contributes to every output, based on their size. This is to avoid having a small output consuming the entire withdrawal for itself. Note sure if I'll keep the approach in the end, I'll have the night to think about it.

# Comments

<!-- Additional comments or screenshots to attach if any -->

- [ ] TODO: take into account the withdrawal when doing largest-first (and testing it)
- [ ] TODO: echo the error message change on "ErrInputsDepleted" to integration tests relying on that message.

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


1877: Fix new warnings in HLint v3.1.6 r=Anviking a=rvl

### Overview

HLint v3.1.6 can find more unused language extensions.

### Comments

CI version update in PR #1857.


Co-authored-by: KtorZ <[email protected]>
Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2020

Build failed (retrying...)

iohk-bors bot added a commit that referenced this pull request Jul 8, 2020
1877: Fix new warnings in HLint v3.1.6 r=Anviking a=rvl

### Overview

HLint v3.1.6 can find more unused language extensions.

### Comments

CI version update in PR #1857.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 8, 2020

Canceled

@KtorZ KtorZ merged commit 368c038 into master Jul 8, 2020
@KtorZ KtorZ deleted the rvl/hlint-v3.1.6 branch July 8, 2020 20:03
iohk-bors bot added a commit that referenced this pull request Jul 8, 2020
1857: Better nix-shell r=KtorZ a=rvl

### Overview

- Uses new Haskell.nix features to put haskell tools in the nix-shell.
- Adds bech32, cardano-address, cardano-tx to the nix-shell.
- Adds these tools to the release archives ("Adrestia tool belt").
- Adds automated tests to the release archives.
- Add nix option for building libraries and exes with profiling enabled.
- Add bash completion for select tools in nix-shell.

### Comments

- Merge #1877 first.


Co-authored-by: Rodney Lorrimar <[email protected]>
iohk-bors bot added a commit that referenced this pull request Jul 10, 2020
1857: Better nix-shell r=KtorZ a=rvl

### User story

ADP-369

### Overview

- Uses new Haskell.nix features to put haskell tools in the nix-shell.
- Adds bech32, cardano-address, cardano-tx to the nix-shell.
- Adds these tools to the release archives ("Adrestia tool belt").
- Adds automated tests to the release archives.
- Add nix option for building libraries and exes with profiling enabled.
- Add bash completion for select tools in nix-shell.

### Comments

- Merge #1877 first.


1894: Getting minimum utxo r=paweljakubas a=paweljakubas

# Issue Number

<!-- Put here a reference to the issue this PR relates to and which requirements it tackles -->
#1893 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] I have extended `ProtocolParameters` and `ApiNetworkParameters`
- [x] I have updated swagger
- [x] I have used minimumUtxoValue in feeOpts in determination of dustThreshold
- [x] I have updated testing
- [x] I have handled migration

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Rodney Lorrimar <[email protected]>
Co-authored-by: Pawel Jakubas <[email protected]>
Co-authored-by: KtorZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants